Remove the ID generator from AutoHCK #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I agree with the PR message. Who will allocate the IDs in the near future? |
We don't need this in the near future. Currently, we run only one HCK-CI on the server. If we change this, Jenkins can assign an ID. |
AutoHCK is a CI runner, not a manager, and should not control resources between different runs. Add command line argument to have the ability to specify an ID that is received from external tools. Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>
We can use Jenkins EXECUTOR_NUMBER env to assign id in case of multiple test runs. |
akihikodaki
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutoHCK is a CI runner, not a manager, and should not control resources between different runs.
Add command line argument to have the ability to specify an ID that is received from external tools.