Fix "time_to_second" helper #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostyanf14
requested changes
Feb 12, 2024
akihikodaki
requested changes
Feb 13, 2024
There was a problem hiding this comment.
Please add tests if you are not in a hurry. Use the test cases from .NET:
https://github.com/dotnet/runtime/blob/v8.0.1/src/libraries/System.Memory/tests/ParsersAndFormatters/Parser/TestData.Parser.TimeSpan.cs#L181-L206
You don't need to test the cases of leading whitespaces, negative values, and illegal cases. Such cases should never happen.
Jedoku
force-pushed
the
Fix-time-1-00-00-00-parse
branch
from
b98b042
to
7f3dfe9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rubocop found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
kostyanf14
reviewed
Feb 13, 2024
Jedoku
force-pushed
the
Fix-time-1-00-00-00-parse
branch
from
f956c24
to
8e065cd
Compare
akihikodaki
requested changes
Feb 13, 2024
Jedoku
force-pushed
the
Fix-time-1-00-00-00-parse
branch
2 times, most recently
from
7de986f
to
9aaaf50
Compare
|
@Jedoku LGTM Please combine all your changes into one or two commits. For each review iteration, you should fix the original commits. |
Jedoku
force-pushed
the
Fix-time-1-00-00-00-parse
branch
2 times, most recently
from
4038876
to
60b63bb
Compare
|
@Jedoku You missed |
Signed-off-by: Vitalii Chulak <vitalii@daynix.com>
Jedoku
force-pushed
the
Fix-time-1-00-00-00-parse
branch
from
60b63bb
to
deefaf7
Compare
kostyanf14
approved these changes
Feb 14, 2024
akihikodaki
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.