Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enclose MESG in do...while loop #2576

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Enclose MESG in do...while loop #2576

merged 3 commits into from
Mar 17, 2023

Conversation

glennsong09
Copy link
Contributor

No description provided.

@derobins derobins added Merge - To 1.12 Merge - To 1.14 This needs to be merged to HDF5 1.14 Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Component - Parallel Parallel HDF5 (NOT thread-safety) Component - Testing Code in test or testpar directories, GitHub workflows Type - Improvement Improvements that don't add a new feature or functionality labels Mar 17, 2023
@derobins derobins merged commit dfa4d55 into HDFGroup:develop Mar 17, 2023
lrknox pushed a commit to lrknox/hdf5 that referenced this pull request Mar 17, 2023
@glennsong09 @lrknox
Enclose MESG in do...while loop (HDFGroup#2576)
f8bfe8d 
Enclose MSG macro in a do...while loop
lrknox pushed a commit to lrknox/hdf5 that referenced this pull request Mar 17, 2023
@glennsong09 @lrknox
Enclose MESG in do...while loop (HDFGroup#2576)
4de3e88 
Enclose MSG macro in a do...while loop
lrknox pushed a commit to lrknox/hdf5 that referenced this pull request Mar 17, 2023
@glennsong09 @lrknox
Enclose MESG in do...while loop (HDFGroup#2576)
2e7d31a 
Enclose MSG macro in a do...while loop
derobins added a commit that referenced this pull request Mar 18, 2023
@lrknox @markcmiller86
@glennsong09 @derobins @e4t
Minor merges to 1.10 (#2579)
a01f570 
* Elaborate how cd_values get stored (#2522)

* Enclose MESG in do...while loop (#2576)

Enclose MSG macro in a do...while loop

* Add a clang-format comment about permissions (#2577)

* Check for overflow when calculating on-disk attribute data size (#2459)

* Remove duplicate code

Signed-off-by: Egbert Eich <eich@suse.com>

* Add test case for CVE-2021-37501

Bogus sizes in this test case causes the on-disk data size
calculation in H5O__attr_decode() to overflow so that the
calculated size becomes 0. This causes the read to overflow
and h5dump to segfault.
This test case was crafted, the test file was not directly
generated by HDF5.
Test case from:
https://github.com/ST4RF4LL/Something_Found/blob/main/HDF5_v1.13.0_h5dump_heap_overflow.md

---------

Co-authored-by: Mark (he/his) C. Miller <miller86@llnl.gov>
Co-authored-by: glennsong09 <43005495+glennsong09@users.noreply.github.com>
Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>
Co-authored-by: Egbert Eich <eich@suse.com>
lrknox added a commit that referenced this pull request Apr 4, 2023
@lrknox @glennsong09
@derobins @jhendersonHDF @e4t
Minor cherry-pick merges to 1.14 (#2582)
37a8e30 
* Enclose MESG in do...while loop (#2576)

Enclose MSG macro in a do...while loop

* Add a clang-format comment about permissions (#2577)

* Remove an obsolete comment from the MDS test (#2578)

The seed is now broadcast from rank 0, so the warning about multiple
machines having different seeds is unnecessary.

* Subfiling VFD - fix issues with I/O concentrator selection strategies (#2571)

Fix multiple bugs with the SELECT_IOC_EVERY_NTH_RANK and
SELECT_IOC_TOTAL I/O concentrator selection strategies and add a
regression test for them

* Check for overflow when calculating on-disk attribute data size (#2459)

* Remove duplicate code

Signed-off-by: Egbert Eich <eich@suse.com>

* Add test case for CVE-2021-37501

Bogus sizes in this test case causes the on-disk data size
calculation in H5O__attr_decode() to overflow so that the
calculated size becomes 0. This causes the read to overflow
and h5dump to segfault.
This test case was crafted, the test file was not directly
generated by HDF5.
Test case from:
https://github.com/ST4RF4LL/Something_Found/blob/main/HDF5_v1.13.0_h5dump_heap_overflow.md

---------

Co-authored-by: glennsong09 <43005495+glennsong09@users.noreply.github.com>
Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>
Co-authored-by: jhendersonHDF <jhenderson@hdfgroup.org>
Co-authored-by: Egbert Eich <eich@suse.com>
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request May 17, 2023
@glennsong09 @brtnfld
Enclose MESG in do...while loop (HDFGroup#2576)
7fb49b7 
Enclose MSG macro in a do...while loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derobins derobins derobins approved these changes

@byrnHDF byrnHDF byrnHDF approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - Parallel Parallel HDF5 (NOT thread-safety) Component - Testing Code in test or testpar directories, GitHub workflows Merge - To 1.14 This needs to be merged to HDF5 1.14 Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glennsong09 @derobins @byrnHDF