Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subfiling VFD - fix issues with I/O concentrator selection strategies #2571

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Subfiling VFD - fix issues with I/O concentrator selection strategies #2571

merged 1 commit into from
Mar 17, 2023

Conversation

jhendersonHDF
Copy link
Collaborator

Fix multiple bugs with the SELECT_IOC_EVERY_NTH_RANK and SELECT_IOC_TOTAL I/O concentrator selection strategies and add a regression test for them

@jhendersonHDF
Subfiling VFD - fix issues with I/O concentrator selection strategies
a106dd9 
Fix multiple bugs with the SELECT_IOC_EVERY_NTH_RANK and
SELECT_IOC_TOTAL I/O concentrator selection strategies and add a
regression test for them
@jhendersonHDF jhendersonHDF added Merge - To 1.14 This needs to be merged to HDF5 1.14 Priority - 1. High 🔼 These are important issues that should be resolved in the next release Component - C Library Core C library issues (usually in the src directory) Component - Testing Code in test or testpar directories, GitHub workflows Type - Bug Please report security issues to help@hdfgroup.org instead of creating an issue on GitHub labels Mar 15, 2023
@jhendersonHDF jhendersonHDF mentioned this pull request Mar 15, 2023
Open
@lrknox lrknox merged commit 1392b9f into HDFGroup:develop Mar 17, 2023
lrknox pushed a commit to lrknox/hdf5 that referenced this pull request Mar 17, 2023
@jhendersonHDF @lrknox
Subfiling VFD - fix issues with I/O concentrator selection strategies (…
cd43bb8 
…HDFGroup#2571)

Fix multiple bugs with the SELECT_IOC_EVERY_NTH_RANK and
SELECT_IOC_TOTAL I/O concentrator selection strategies and add a
regression test for them
jhendersonHDF added a commit to jhendersonHDF/hdf5 that referenced this pull request Mar 20, 2023
@jhendersonHDF
Subfiling VFD - fix issues with I/O concentrator selection strategies (…
6769970 
…HDFGroup#2571)

Fix multiple bugs with the SELECT_IOC_EVERY_NTH_RANK and
SELECT_IOC_TOTAL I/O concentrator selection strategies and add a
regression test for them
@jhendersonHDF jhendersonHDF mentioned this pull request Mar 20, 2023
Merged
lrknox pushed a commit that referenced this pull request Apr 4, 2023
@jhendersonHDF
Subfiling VFD - fix issues with I/O concentrator selection strategies (…
101210c 
…#2571) (#2618)

Fix multiple bugs with the SELECT_IOC_EVERY_NTH_RANK and
SELECT_IOC_TOTAL I/O concentrator selection strategies and add a
regression test for them
lrknox added a commit that referenced this pull request Apr 4, 2023
@lrknox @glennsong09
@derobins @jhendersonHDF @e4t
Minor cherry-pick merges to 1.14 (#2582)
37a8e30 
* Enclose MESG in do...while loop (#2576)

Enclose MSG macro in a do...while loop

* Add a clang-format comment about permissions (#2577)

* Remove an obsolete comment from the MDS test (#2578)

The seed is now broadcast from rank 0, so the warning about multiple
machines having different seeds is unnecessary.

* Subfiling VFD - fix issues with I/O concentrator selection strategies (#2571)

Fix multiple bugs with the SELECT_IOC_EVERY_NTH_RANK and
SELECT_IOC_TOTAL I/O concentrator selection strategies and add a
regression test for them

* Check for overflow when calculating on-disk attribute data size (#2459)

* Remove duplicate code

Signed-off-by: Egbert Eich <eich@suse.com>

* Add test case for CVE-2021-37501

Bogus sizes in this test case causes the on-disk data size
calculation in H5O__attr_decode() to overflow so that the
calculated size becomes 0. This causes the read to overflow
and h5dump to segfault.
This test case was crafted, the test file was not directly
generated by HDF5.
Test case from:
https://github.com/ST4RF4LL/Something_Found/blob/main/HDF5_v1.13.0_h5dump_heap_overflow.md

---------

Co-authored-by: glennsong09 <43005495+glennsong09@users.noreply.github.com>
Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>
Co-authored-by: jhendersonHDF <jhenderson@hdfgroup.org>
Co-authored-by: Egbert Eich <eich@suse.com>
@jhendersonHDF jhendersonHDF deleted the feature/subfiling branch April 17, 2023 20:12
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request May 17, 2023
@jhendersonHDF @brtnfld
Subfiling VFD - fix issues with I/O concentrator selection strategies (…
1f3f7fb 
…HDFGroup#2571)

Fix multiple bugs with the SELECT_IOC_EVERY_NTH_RANK and
SELECT_IOC_TOTAL I/O concentrator selection strategies and add a
regression test for them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrknox lrknox lrknox approved these changes

@bmribler bmribler bmribler approved these changes

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@byrnHDF byrnHDF Awaiting requested review from byrnHDF byrnHDF is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - C Library Core C library issues (usually in the src directory) Component - Testing Code in test or testpar directories, GitHub workflows Merge - To 1.14 This needs to be merged to HDF5 1.14 Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Bug Please report security issues to help@hdfgroup.org instead of creating an issue on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhendersonHDF @lrknox @bmribler