Remove unneeded vars from DPE

HDFGroup · Nov 28, 2022 · db68ba6 · db68ba6
1 parent 0ab52cf
commit db68ba6
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 14 deletions.
diff --git a/CMake/Testing/Temporary/CTestCostData.txt b/CMake/Testing/Temporary/CTestCostData.txt
diff --git a/CMake/Testing/Temporary/LastTest.log b/CMake/Testing/Temporary/LastTest.log
diff --git a/adapter/mapper/abstract_mapper.h b/adapter/mapper/abstract_mapper.h
@@ -59,7 +59,7 @@ struct BlobPlacement {
     return ss.str();
   }
 
-  /** decode a BLOB name by splitting it into index, offset, size,
+  /** decode \a blob_name BLOB name by splitting it into index, offset, size,
         and rank. */
   void DecodeBlobNameLogEntry(const std::string &blob_name) {
     auto str_split =

diff --git a/data_stager/stagers/posix_stager.cc b/data_stager/stagers/posix_stager.cc
@@ -26,7 +26,7 @@ void PosixStager::StageIn(std::string path, PlacementPolicy dpe) {
   } else if (stdfs::is_directory(path)) {
     DirectoryStageIn(path, dpe);
   } else {
-    LOG(ERROR) << "Unix stage in is neither a file or directory" << std::endl;
+    LOG(ERROR) << "Posix stage in is neither a file or directory" << std::endl;
   }
 }
 
@@ -48,10 +48,10 @@ void PosixStager::StageIn(std::string path, off_t off,
   if (stdfs::is_regular_file(path)) {
     FileStageIn(path, off, size, dpe);
   } else if (stdfs::is_directory(path)) {
-    LOG(ERROR) << "Unix stage-in with offset " <<
+    LOG(ERROR) << "Posix stage-in with offset " <<
         "is not supported for directories" << std::endl;
   } else {
-    LOG(ERROR) << "Unix stage-in is neither a file or directory" << std::endl;
+    LOG(ERROR) << "Posix stage-in is neither a file or directory" << std::endl;
   }
 }
 
@@ -74,7 +74,7 @@ void PosixStager::StageOut(std::string path) {
   } else if (stdfs::is_directory(path)) {
     DirectoryStageOut(path);
   } else {
-    LOG(ERROR) << "Unix stage-out is neither a file or directory" << std::endl;
+    LOG(ERROR) << "Posix stage-out is neither a file or directory" << std::endl;
   }
 }
 

diff --git a/src/data_placement_engine.h b/src/data_placement_engine.h
@@ -34,7 +34,6 @@ using hermes::api::PlacementPolicy;
 */
 class DPE {
  protected:
-  bool require_bw_;        /**< check if bandwidth is required */
   PlacementPolicy policy_; /**< data placement policy */
 
  public:

diff --git a/src/dpe/round_robin.cc b/src/dpe/round_robin.cc
@@ -111,10 +111,6 @@ Status RoundRobin::Placement(const std::vector<size_t> &blob_sizes,
   if (ctx.policy != hermes::api::PlacementPolicy::kRoundRobin) {
     return result;
   }
-  if (bandwidths.size()) {
-    require_bw_ = false;
-  }
-
   for (size_t i {0}; i < blob_sizes.size(); ++i) {
     PlacementSchema schema;