Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unique names for test files #114

Closed
ChristopherHogan opened this issue Feb 4, 2021 · 2 comments · Fixed by #117
Closed

Use unique names for test files #114

ChristopherHogan opened this issue Feb 4, 2021 · 2 comments · Fixed by #117
Assignees
@hariharan-devarajan
Labels
testing Related to automated testing or CI

Comments

@ChristopherHogan
Copy link
Collaborator

trait_test.cc is failing on Ares for me because Kimmy already has a file called /tmp/test.dat and I don't have permissions to overwrite it. Maybe we could add the PID or username to the file name to make it unique.
@hariharan-devarajan
@ChristopherHogan
Copy link
Collaborator Author

Same goes for the adapter tests.

@ChristopherHogan ChristopherHogan added the testing Related to automated testing or CI label Feb 4, 2021
@hariharan-devarajan hariharan-devarajan linked a pull request Feb 8, 2021 that will close this issue
Hariharan/unique names #117
Merged
@hariharan-devarajan
Copy link
Collaborator

I had added for all trait and adapter tests PR #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hariharan-devarajan hariharan-devarajan

Labels
testing Related to automated testing or CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hariharan/unique names hariharan-devarajan/hermes
2 participants
@ChristopherHogan @hariharan-devarajan