Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hariharan/unique names #117

Merged
merged 8 commits into from
Feb 9, 2021
Merged

Hariharan/unique names #117

merged 8 commits into from
Feb 9, 2021

Conversation

hariharan-devarajan
Copy link
Collaborator

@hariharan-devarajan hariharan-devarajan commented Feb 5, 2021 •
edited
Loading

This PR Fixes #117 for creating unique names. I am using PID to distinguish file names.

@coveralls
Copy link

coveralls commented Feb 5, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 552443982

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.668%
Totals Coverage Status
Change from base Build 552417897: 0.0%
Covered Lines: 4803
Relevant Lines: 5954
💛 - Coveralls

@ChristopherHogan
Copy link
Collaborator

Could you please remove the license changes so they don't conflict with Kimmy's #113?

@hariharan-devarajan
Copy link
Collaborator Author

Could you please remove the license changes so they don't conflict with Kimmy's #113?

Removed the license and fixed the conflicts.

@hariharan-devarajan hariharan-devarajan linked an issue Feb 8, 2021 that may be closed by this pull request
Use unique names for test files #114
Closed
@hariharan-devarajan hariharan-devarajan mentioned this pull request Feb 9, 2021
Closed
@ChristopherHogan
Copy link
Collaborator

Can you add the PID to the cmp files you added in #110?

@hariharan-devarajan
Merge pull request #21 from HDFGroup/master
6afc81b 
Get the latest from hermes master.
@hariharan-devarajan
Copy link
Collaborator Author

cmp

I got the latest from the master. Now it has the getpid on all names.

@ChristopherHogan ChristopherHogan merged commit b10a211 into HDFGroup:master Feb 9, 2021
@hariharan-devarajan hariharan-devarajan deleted the hariharan/unique_names branch March 4, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherHogan ChristopherHogan ChristopherHogan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use unique names for test files
3 participants
@hariharan-devarajan @coveralls @ChristopherHogan