Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kimmy/copying #113

Merged
merged 3 commits into from
Feb 6, 2021
Merged

Kimmy/copying #113

merged 3 commits into from
Feb 6, 2021

Conversation

jya-kmu
Copy link
Contributor

@jya-kmu jya-kmu commented Feb 2, 2021

Fix alignment issue.

@coveralls
Copy link

coveralls commented Feb 3, 2021 •
edited

Pull Request Test Coverage Report for Build 541259323

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.456%
Totals Coverage Status
Change from base Build 522452615: 0.0%
Covered Lines: 4236
Relevant Lines: 5265
💛 - Coveralls

@ChristopherHogan
Copy link
Collaborator

Several files (adapter/src/hermes/adapter/stdio/common/constants.h for example) still reference "COPYFILE" instead of "the COPYING file."

@ChristopherHogan ChristopherHogan mentioned this pull request Feb 5, 2021
Merged
@jya-kmu jya-kmu merged commit a18d960 into master Feb 6, 2021
@jya-kmu jya-kmu deleted the kimmy/copying branch February 6, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherHogan ChristopherHogan ChristopherHogan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jya-kmu @coveralls @ChristopherHogan