Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kimmy/glog initialization #273

Merged
merged 7 commits into from
Nov 5, 2021
Merged

Kimmy/glog initialization #273

merged 7 commits into from
Nov 5, 2021

Conversation

jya-kmu
Copy link
Contributor

@jya-kmu jya-kmu commented Nov 4, 2021 •
edited
Loading

Initialize glog in InitHermes and shut down in hermes::Finalize

This simple version works fine with CI

@ChristopherHogan
Copy link
Collaborator

I'm still seeing WARNING: Logging before InitGoogleLogging() is written to STDERR in all the adapter tests.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 81.216% when pulling ff079ba on kimmy/glog_initialization into 4eccb20 on master.

@ChristopherHogan
Copy link
Collaborator

We also need to shutdown GLOG at the end of rpc_thallium.cc:FinalizeClient.

@jya-kmu jya-kmu merged commit e4e81dd into master Nov 5, 2021
@jya-kmu jya-kmu deleted the kimmy/glog_initialization branch November 5, 2021 00:34
@ChristopherHogan ChristopherHogan mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherHogan ChristopherHogan ChristopherHogan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jya-kmu @ChristopherHogan @coveralls