Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for checkpoint/restart workflow #293

Merged
merged 6 commits into from
Nov 12, 2021

Conversation

ChristopherHogan
Copy link
Collaborator

@ChristopherHogan ChristopherHogan commented Nov 10, 2021

  • Add HERMES_CLIENT environment variable so that a single client app can connect to an existing Hermes daemon. Fixes Need a better way to distinguish daemon vs. client in adapters #206.
  • Populate AdapterStat::st_size when an adapter client detects that a Bucket already exists in Hermes.
  • Don't overwrite GLOG_minloglevel if it's already set.
  • Fix some integer overflows in buffer_pool.cc.
  • Return an error Status when CalculatePlacement can't find any valid Targets.
  • Take the bucket mutex when retrieving a Bucket's BlobIDs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 80.852% when pulling 8c292d3 on chogan/checkpoint_restart into d581dab on master.

@ChristopherHogan ChristopherHogan added adapter-posix Related to the POSIX adapter bug Something isn't working labels Nov 11, 2021
@ChristopherHogan ChristopherHogan merged commit 5ca8a7e into master Nov 12, 2021
@ChristopherHogan ChristopherHogan deleted the chogan/checkpoint_restart branch November 12, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapter-posix Related to the POSIX adapter bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a better way to distinguish daemon vs. client in adapters
3 participants