Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAPT] Enable HERMES_PAGE_SIZE and HERMES_WRITE_ONLY in posix adapter #299

Merged
merged 2 commits into from
Nov 18, 2021
Merged

[ADAPT] Enable HERMES_PAGE_SIZE and HERMES_WRITE_ONLY in posix adapter #299

merged 2 commits into from
Nov 18, 2021

Conversation

ChristopherHogan
Copy link
Collaborator

Fixes #253.

  • Move kPageSize to adapter/constants.h so it can be used by all adapters.
  • Remove unused hermes_*_internal.so adapter libraries.
  • Make posix.cc:write_internal and stdio.cc:write_internal as similar as possible to facilitate future refactoring.
  • Add adapter/utils.cc for functions common to all adapters.

@ChristopherHogan ChristopherHogan added the enhancement New feature or request label Nov 16, 2021
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 80.797% when pulling a1ff61e on chogan/issue_253 into ddceb25 on master.

@ChristopherHogan ChristopherHogan merged commit a645ecc into master Nov 18, 2021
@ChristopherHogan ChristopherHogan deleted the chogan/issue_253 branch November 18, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jya-kmu jya-kmu jya-kmu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable controlling page size and write-only option in POSIX adapter
3 participants
@ChristopherHogan @coveralls @jya-kmu