Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize adapter file structure and simplify CMake files #315

Merged
merged 2 commits into from
Jan 6, 2022

Conversation

ChristopherHogan
Copy link
Collaborator

This work is in preparation for adding the VFD to the hermes/adapter folder, and in anticipation of having a base adapter layer that all adapters can share.

  • Replaced all instances of include_directories with the preferred target_include_directories in CMake files.
  • Removed empty directories.
  • Added a missing install command for the mpiio adapter tests.
  • Simplified CMake files by putting more commands in foreach loops.

@ChristopherHogan ChristopherHogan added adapter-stdio Relates to the STDIO adapter adapter-mpiio Related to the MPI-IO adapter adapter-posix Related to the POSIX adapter skip-changelog PRs with this label won't be auto-filled in the release notes labels Jan 6, 2022
@ChristopherHogan ChristopherHogan self-assigned this Jan 6, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 81.05% when pulling 3bc2a8c on chogan/adapter_reorg into 600c9a0 on master.

@ChristopherHogan ChristopherHogan merged commit dca824a into master Jan 6, 2022
@ChristopherHogan ChristopherHogan deleted the chogan/adapter_reorg branch January 6, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapter-mpiio Related to the MPI-IO adapter adapter-posix Related to the POSIX adapter adapter-stdio Relates to the STDIO adapter skip-changelog PRs with this label won't be auto-filled in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants