Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fieldop #292

Merged
merged 10 commits into from
Dec 13, 2023
Merged

Fieldop #292

merged 10 commits into from
Dec 13, 2023

Conversation

jreadey
Copy link
Member

@jreadey jreadey commented Dec 8, 2023

Add support for sub-field selection in hyperslab, point, and query operations for both reading and write.
To specify which fields of a compound type are to be accessed, add a query param or body key of "fields". For a single field selection the query value can just be the field name. If multiple fields are to be accessed, concatenate the field names with a colon separator.

@jreadey jreadey requested a review from mattjala December 8, 2023 15:00
mattjala
mattjala previously approved these changes Dec 8, 2023
@mattjala
Copy link
Contributor

CodeQL's warning in hsds_logger.py about logging a password seems to be a false positive from printing the username in authUtil.py:321. I think should probably remove it anyway to keep the warnings clean.

The warnings in fileClient also want filepath to be processed to avoid malicious or unusual paths - that should be a quickfix like in the example here.

Besides the CodeQL issues, LGTM.

@jreadey jreadey merged commit ab05703 into master Dec 13, 2023
9 of 10 checks passed
@jreadey jreadey deleted the fieldop branch December 13, 2023 03:15
@mattjala mattjala mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants