Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Update) Use queued announce updates #3448

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

Roardom
Copy link
Collaborator

@Roardom Roardom commented Jan 30, 2024

There were very minor edge cases with the previous system that had issues when users paused a torrent immediately after they completed it, causing data to be duplicated. We now opt to use DTOs to transfer the data into the job queue instead of models to prevent the extra database queries caused by passing models into a job queue.

Still requires testing.

@Roardom Roardom force-pushed the queued-announce branch 2 times, most recently from c65d5cb to eb2e598 Compare February 4, 2024 04:37
There were very minor edge cases with the previous system that had issues when users paused a torrent immediately after they completed it, causing data to be duplicated. We now opt to use DTOs to transfer the data into the job queue instead of models to prevent the extra database queries caused by passing models into a job queue.
Copy link

what-the-diff bot commented Feb 5, 2024

PR Summary

  • Addition of new data transfer object (DTO) files
    A series of new files (AnnounceGroupDTO.php, AnnouncePeerDTO.php, AnnounceQueryDTO.php, AnnounceTorrentDTO.php, AnnounceUserDTO.php) have been added to the app/DTO directory. The new files will help in consistent traffic of data between components in the program.

  • Modifications to the ProcessAnnounce class
    The 'ProcessAnnounce' class, located in the app/Jobs directory, underwent various changes to enhance its functionality. These include:

    • Additional parameters in the constructor: This changes allows for more flexibility during object creation.
    • Inclusion of a new middleware: The addition of a new middleware enhances the class's functionality by providing a way to handle various peripheral concerns.
    • Updates to the handle method: The execution of the handle method has been improved to perform various updates, leading to a more efficient operation.

These changes aim to enhance functionality and improve the overall efficiency of the system.

@HDVinnie HDVinnie marked this pull request as ready for review February 5, 2024 01:54
- hex2bin is already performed in the DTO
@HDVinnie HDVinnie merged commit 3cd50dd into HDInnovations:7.x.x Feb 5, 2024
5 checks passed
@HDVinnie HDVinnie deleted the queued-announce branch February 5, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants