Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections for a new tag compatible with FCCSW v0.9 #53

Merged
merged 8 commits into from
Jan 15, 2018

Conversation

vvolkl
Copy link
Member

@vvolkl vvolkl commented Jan 15, 2018

  • Remove overloaded operators << that conflict with podio and replace them with a function returning a string (sub-optimal from a user point of view, but only way to make it work with the current version of podio as far as I can see)
  • Restructure the Hit information needed for Digitization so that PositionedTrackHit can still be used in its previous form

@fcc-bot
Copy link

fcc-bot commented Jan 15, 2018

Failure: The build or some tests failed.

@fcc-bot
Copy link

fcc-bot commented Jan 15, 2018

Failure: The build or some tests failed.

@vvolkl
Copy link
Member Author

vvolkl commented Jan 15, 2018

retest this please

@fcc-bot
Copy link

fcc-bot commented Jan 15, 2018

Failure: The build or some tests failed.

@fcc-bot
Copy link

fcc-bot commented Jan 15, 2018

Success: Build complete and tests passed.

edm.yaml Outdated
- fcc::BareHit core // The hit

fcc::DigiTrackHitAAssociation:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo (double A)

@fcc-bot
Copy link

fcc-bot commented Jan 15, 2018

Success: Build complete and tests passed.

@zaborowska zaborowska merged commit e3206e1 into HEP-FCC:master Jan 15, 2018
@JavierCVilla JavierCVilla mentioned this pull request Jan 15, 2018
@vvolkl vvolkl deleted the fccsw-v0.9 branch March 2, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants