Merging development branch into master

[kreczko]

Summary

This particular release (up to commit e279a5e) has been in production for almost a year and is also available on puppet forge.
The last two versions (1.3.0 and 1.3.1) have been created and can be used as backup.

The 2.0 release contains many improvements including Alessandra's latest changes in issue #58 and #59 (adjusted for changes in 2.0).

Most notable changes

htcondor::params.pp was added to set defaults for all the parameters.
In addition, parameters are attempted to be read via hiera first. Full merge
support for hashes and arrays is provided.
With these changes the htcondor::config.pp was split into six pieces:

• the main config setting up the rest
• a common config part
• the security configuration
• separate configs for manager, scheduler & worker
  The full detail of these changes can be seen in PR 53.

New features

• configure connection broker for private workers (i.e. workers that cannot be reached from the manager or scheduler but can reach the manager).
• enabled ganglia daemon for schedulers (previously only possible on managers)
• flag to enable condor reporting, disabed by default
• added use_anonymous_auth
• added custom_machine_attributes and custom_machine_attributes which can be used to add classads for STARTD_ATTRS and STARTD_JOB_ATTRS

Bug fixes

• daemon list would be incorrect for some versions of Ruby. This was due to the use of and and or operators which is incorrect for boolean comparisons.
• added missing cluster_has_multiple_domains parameter (w.r.t to 2.0.0 beta)
• removed repository dependency if it is disabled

Other

• changed config templates to ensure new line at the end of the file and reduced the use of -%>
• workers are no longer able to write to schedulers by default
• new formatting for the security config: one line per entry for manager/scheduler/worker
• removed use_pkg_config parameter.
• no longer changing /etc/condor/condor_config nor /etc/condor/condor_config.local as recommended by the HTCondor team
• content previously in /etc/condor/condor_config.local now in /etc/condor/config.d/00_config_local.config

[kreczko]

@fschaer @kashif74 @afortiorama
Unless you have objections, I would like to merge this soon.
Locally you all are probably using a fixed version, so production instances would be unaffected.

[afortiorama]

It's fine by me.

[fschaer]

Hi, Fine with me too.. I’ll test the differences locally before merging with production modules. Thanks