-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big simplifications #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kreczko
force-pushed
the
better-module
branch
from
February 16, 2016 14:59
891587c
to
3bc9016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes big simplifications for how the configuration is done.
params.pp
. All parameters attempt to read thehiera
value first.init.pp
contains the full list of parameters, other modules import them:config.pp
has been split acrosscommon.pp
,worker.pp
,manager.pp
,scheduler.pp
condor_reconfig
on configuration change has been simplifiedThere is more coming, but the PR is very big already. I wanted to put this one out to see if everyone would be happy with such a change. The manifests should be easier to read and understand.
As with the past two PRs I will merge this one into the development branch.