Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big simplifications #53

Merged
merged 17 commits into from
Feb 17, 2016
Merged

Big simplifications #53

merged 17 commits into from
Feb 17, 2016

Conversation

kreczko
Copy link
Member

@kreczko kreczko commented Feb 10, 2016

This PR includes big simplifications for how the configuration is done.

  • First of all, all default parameters have been moved to params.pp. All parameters attempt to read the hiera value first.
$enable_cgroup = hiera('enable_cgroup', false)
  • Only init.pp contains the full list of parameters, other modules import them:
$managers = $htcondor::managers
  • config.pp has been split across common.pp, worker.pp, manager.pp, scheduler.pp
  • creation of the daemon list and calling condor_reconfig on configuration change has been simplified
  • added a hiera example for how to set the parameters
  • renamed computing element to scheduler

There is more coming, but the PR is very big already. I wanted to put this one out to see if everyone would be happy with such a change. The manifests should be easier to read and understand.

As with the past two PRs I will merge this one into the development branch.

@kreczko kreczko added this to the Version 2.0 milestone Feb 10, 2016
@kreczko kreczko mentioned this pull request Feb 10, 2016
3 tasks
kreczko added a commit that referenced this pull request Feb 17, 2016
@kreczko kreczko merged commit 5716ba2 into HEP-Puppet:development Feb 17, 2016
@kreczko kreczko deleted the better-module branch February 17, 2016 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant