Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invenio-accounts: migrate from v4.0.2 to v5.0.0 #783

Closed
GraemeWatt opened this issue Mar 26, 2024 · 0 comments
Closed

invenio-accounts: migrate from v4.0.2 to v5.0.0 #783

GraemeWatt opened this issue Mar 26, 2024 · 0 comments
Assignees
@GraemeWatt
Labels
complexity: low priority: high type: bug Indicates an unexpected problem or unintended behaviour

Comments

@GraemeWatt
Copy link
Member

The Dependabot PR #780 bumps invenio-accounts from v4.0.2 to v5.0.0, but the end-to-end tests fail. Testing the dependabot/pip/invenio-accounts-5.0.0 branch locally, the http://localhost:5000/login/ endpoint gives an exception:

jinja2.exceptions.UndefinedError: 'flask.config.Config object' has no attribute 'ACCOUNTS_COVER_TEMPLATE'

Probably it is necessary to call set_default_config(app) when initialising the app in ext.py.
@GraemeWatt GraemeWatt added type: bug Indicates an unexpected problem or unintended behaviour priority: high complexity: low labels Mar 26, 2024
@GraemeWatt GraemeWatt self-assigned this Mar 26, 2024
GraemeWatt added a commit that referenced this issue Mar 27, 2024
@GraemeWatt
Revert "ext: call set_default_config (closes #783)"
8c69503 
This reverts commit 27a5f05.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GraemeWatt GraemeWatt

Labels
complexity: low priority: high type: bug Indicates an unexpected problem or unintended behaviour
Projects
@HEPData
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GraemeWatt