Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify behaviour if zero uncertainties #251

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

GraemeWatt
Copy link
Member

@GraemeWatt GraemeWatt commented Feb 13, 2024


📚 Documentation preview 📚: https://hepdata-lib--251.org.readthedocs.build/en/251/

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2287c18) 87.70% compared to head (765680e) 87.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   87.70%   87.99%   +0.28%     
==========================================
  Files           5        5              
  Lines        1082     1083       +1     
  Branches      231      231              
==========================================
+ Hits          949      953       +4     
+ Misses         93       91       -2     
+ Partials       40       39       -1     
Flag Coverage Δ
unittests-3.10 87.99% <100.00%> (+0.28%) ⬆️
unittests-3.6 87.68% <100.00%> (+0.29%) ⬆️
unittests-3.7 87.68% <100.00%> (+0.29%) ⬆️
unittests-3.8 87.81% <100.00%> (+0.28%) ⬆️
unittests-3.9 87.81% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@clelange clelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! I'm just wondering whether at some point hepdata_lib should actually support this, so we can keep the issue open for now.

@clelange clelange merged commit 720c6d8 into main Feb 14, 2024
16 checks passed
@clelange clelange deleted the clarify_zero_uncertainties branch February 14, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants