Refactoring.

[AndreasAlbert]

First stab at #57. Any thoughts @clelange?

[AndreasAlbert]

Utility functions now live in helpers subspace. Everything to do with ROOT data formats moved to RootUtils.

[coveralls]

Pull Request Test Coverage Report for Build 303

• 192 of 247 (77.73%) changed or added relevant lines in 3 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.8%) to 74.029%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
hepdata_lib/init.py	6	13	46.15%
hepdata_lib/helpers.py	38	49	77.55%
hepdata_lib/root_utils.py	148	185	80.0%

Files with Coverage Reduction	New Missed Lines	%
hepdata_lib/init.py	1	69.02%

Totals
Change from base Build 283:	0.8%
Covered Lines:	362
Relevant Lines:	489

---

💛 - Coveralls

[clelange]

Hi Andreas,

In general, this looks very good to me. I think it's good to abstract away the classes that should not be used by the user to some extent.
Could you reenable the pylint option for the > 1000 lines file?

It's a little bit inconsistent to use CamelCase for RooUtils and then all lower case helpers, use snake_case for both? Then we would have a convention that classes that should be used by the user are CamelCase and the other snake_case?

[AndreasAlbert]

Oh yeah, let's just use snake for both.

Guiding the user with the case convention used in the code is a bit too arcane for my taste.

[AndreasAlbert]

To be more precise:
CamelCase for class names, snake for everything else (which is what we did so far, I think)

[clelange]

I think there's only one error left:

hepdata_lib/__init__.py:258:12: E0602: Undefined variable 'execute_command' (undefined-variable)

[AndreasAlbert]

• Fixed pylint errors
• Applied snake_case to RootUtils submodule -> root_utils
• Travis now runs pylint on all python sub files

[clelange]

Thanks a lot for this work! Things look good, but one concern: Now that e.g. the RootFileReader isn't a top-level import anymore, access will be broken for all users.
I think we should circumvent that by adding import statements in __init__.py or what is your opinion?
It would probably make sense to have as additional test an example analysis (e.g. one that's already on HEPData) to see if things break for users.

[clelange]

We actually don't need the ROOT and numpy imports here anymore, do we?

[AndreasAlbert]

Yes, removed.

[AndreasAlbert]

You are right about the backward compatibility. For now, I added an import to the main file as per your suggestion. Longer term, we should encourage users to switch their import statements.

[clelange]

I'll work on #60 first so that we have a working docker container and binder examples again. Will get to it this week.

[AndreasAlbert]

If #60 is not a code issue on our side, why does this PR need to wait for it?