Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: add pyproject to allow installing from empty environment #61

Merged
merged 20 commits into from Feb 22, 2021

Conversation

steven-murray
Copy link
Contributor

This just adds a simple pyproject.toml that makes it possible to install this package into an env that doesn't already have numpy installed.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.65% when pulling e0c00ec on pyproject into 63110c8 on master.

@plaplant
Copy link
Member

@steven-murray thanks for the change! I think we also want to move from Travis to GitHub Actions for the CI on this repo. I can set that up as part of this PR.

@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@63110c8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #61   +/-   ##
=========================================
  Coverage          ?   47.87%           
=========================================
  Files             ?       17           
  Lines             ?     2258           
  Branches          ?        0           
=========================================
  Hits              ?     1081           
  Misses            ?     1177           
  Partials          ?        0           
Flag Coverage Δ
unittests 47.87% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63110c8...29c4f73. Read the comment docs.

@plaplant
Copy link
Member

As a part of this PR, I've moved the CI builds from Travis to GitHub Actions, moved the coverage reporting from Coveralls to CodeCov, and migrated the test suite from unittest to pytest. These changes bring the repo more in line with others across the organization.

As part of the testing, I have removed the builds on python2.7, and added testing for python3.7, 3.8, and 3.9. I have not explicitly broken compatibility with python2, but I don't think we need to regularly test backwards compatibility any longer now that it has reached end-of-life.

In addition to these changes, I've been more explicit about numpy datatypes, in keeping with the recent deprecation warnings introduced in v1.20. This should hopefully future-proof us a bit.

@steven-murray
Copy link
Contributor Author

Nice updates, @plaplant :-) Looks ready to go!

@plaplant plaplant merged commit 30b8c2b into master Feb 22, 2021
@plaplant plaplant deleted the pyproject branch February 22, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants