Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backwards compatibility for UVPSpec.r_params #220

Closed
nkern opened this issue Aug 28, 2019 · 0 comments
Closed

backwards compatibility for UVPSpec.r_params #220

nkern opened this issue Aug 28, 2019 · 0 comments
Labels

Comments

@nkern
Copy link
Member

nkern commented Aug 28, 2019

The lazy covariance PR added the UVPSpec.r_params attribute, which is generally a dictionary encoded in a JSON string, but we didn't add an exception for reading UVPSpec objects from disk that don't have r_params attribute in their file structure (i.e. files older than the PR itself). @steven-murray alerted us that this was causing hera_stats tests to fail, which does store a static uvp for its testing suite.

This wasn't caught in our normal review process because we don't store static UVPSpec files in our testing directory. #219 addresses this issue specifically with r_params being backwards compatible, but also adds a single, simple static UVPSpec object to the data directory for testing backwards compatibility in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant