Makes r_params backwards compatible for UVPSpec #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and a read test for backwards compat testing
philbull
approved these changes
Aug 29, 2019
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any new parameter added to our file formats (including
PSpecContainerandUVPSpec) must have a catch in theirread()functions to catch for the case that the parameter is not defined.This wasn't caught in our normal review process b/c we don't store static
UVPSpecobjects in our testing directly, and create them on-the-fly in our testing suite. This was done b/c our file format and its API was actively changing, but now that things have settled down I think its a good idea to make one simple staticUVPSpecfile in our data directory to specifically catch these backwards compatibility errors. Therefore, an exampleuvpobject is added to the data dir and a simpleread()test is added totest_uvpspec.addresses #220