Repo cleanup pretag #165
Merged
Repo cleanup pretag #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
still working on one last edit... |
This was referenced Jul 19, 2018
philbull
approved these changes
Jul 19, 2018
| Y = np.vstack([self.Y(key1).diagonal(), self.Y(key2).diagonal()]) | ||
|
|
||
| # Second: check cache for Y | ||
| matches = [np.isclose(Y, y).all() for y in self._identity_Y.values()] |
There was a problem hiding this comment.
This is probably fine, but an alternative would be to hash the array using md5sum.
| @@ -241,6 +242,10 @@ def _blpair_to_antnums(blpair): | |||
| ant2 = int(np.floor(blpair / 1e6 - ant1*1e3)) | |||
| ant3 = int(np.floor(blpair / 1e3 - ant1*1e6 - ant2*1e3)) | |||
| ant4 = int(np.floor(blpair - ant1*1e9 - ant2*1e6 - ant3*1e3)) | |||
| ant1 -= 100 | |||
There was a problem hiding this comment.
Why are these on separate lines? They could just be put into the lines above.
There was a problem hiding this comment.
I don't think so, see how ant2 is dependent on ant1 and so on..
| Gv = self.get_G(key1, key2) | ||
| Hv = self.get_H(key1, key2, sampling=sampling) | ||
| # cache it | ||
| self._identity_Y[(key1, key2)] = Y |
There was a problem hiding this comment.
Just for clarity: This is done per baseline-pair, and not per blpair-time? So the flags still have to remain time-independent?
There was a problem hiding this comment.
Yeah, done per-baselinepair (not time). flags still need to remain time-independent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor changes addressing issues in
UVPSpecandPSpecDatabefore we tag a release