Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed bug in pspec_run.broadcast_dset_flags and incr test cvrg #171

Merged
merged 1 commit into from
Sep 4, 2018
Merged

fixed bug in pspec_run.broadcast_dset_flags and incr test cvrg #171

merged 1 commit into from
Sep 4, 2018

Conversation

nkern
Copy link
Member

@nkern nkern commented Aug 14, 2018

Fixed a minor bug where the spw_ranges kwarg of pspec_run wasn't being propagated to its call to broadcast_dset_flags. Added a test to ensure this is done correctly, and in general tidied up and clarified the various tests in test_pspec_run function.

@ghost ghost assigned nkern Aug 14, 2018
@ghost ghost added the in progress label Aug 14, 2018
@nkern nkern requested a review from philbull August 14, 2018 08:27
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 96.573% when pulling 67b766f on pspec_run_broadcast_flag_fix into e3b22e6 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 96.573% when pulling 67b766f on pspec_run_broadcast_flag_fix into e3b22e6 on master.

philbull
philbull approved these changes Sep 4, 2018
View reviewed changes
Copy link
Collaborator

@philbull philbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved!

@nkern nkern merged commit 24dd782 into master Sep 4, 2018
@ghost ghost removed the in progress label Sep 4, 2018
@nkern nkern deleted the pspec_run_broadcast_flag_fix branch September 4, 2018 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philbull philbull philbull approved these changes

Assignees

@nkern nkern

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nkern @coveralls @philbull