Minor tweaks to improve error handling if arguments are in the wrong format #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
acliu
reviewed
Apr 10, 2019
acliu
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a couple of instances where functions were giving poor or confusing feedback when the wrong (or mis-formatted) arguments were passed. I changed them to give more useful feedback to the user, and also updated some docstrings.
I also allowed users to set
wgts=Nonewhen initialisingPSpecDataobjects (which causes all weights to be set to whatever the flags are in the inputUVDataobjects), and allowed thebaseline_tolkwarg to be user-specified in thepspec()method, as it was previously hard-coded to1.0(this number is passed to thevalidate_blpairs()method).