Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for PSpecData.pspec to pass the little_h option when calculating … #196

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

zacharymartinot
Copy link
Contributor

…the normalization scalar. I didn't look extensively for any other instances of this bug, but this change produced the expected (non-little-h) output power spectrum amplitude.

@ghost ghost assigned zacharymartinot Apr 6, 2019
@ghost ghost added the in progress label Apr 6, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.516% when pulling 6cdbd8f on little_h_fix into 0de985e on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.516% when pulling 6cdbd8f on little_h_fix into 0de985e on master.

Copy link
Member

@nkern nkern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks zac, let's wait to hear from phil if he has anything to say abou it

@philbull
Copy link
Collaborator

This is good. I did notice this, but wherever I fixed it hasn't been merged yet, so let's just merge this PR.

@philbull philbull merged commit f48ae94 into master Apr 10, 2019
@philbull philbull deleted the little_h_fix branch April 10, 2019 09:23
@ghost ghost removed the in progress label Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants