Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use older version of scikit-learn for Python 2.7 tests #202

Merged
merged 1 commit into from
May 10, 2019
Merged

Use older version of scikit-learn for Python 2.7 tests #202

merged 1 commit into from
May 10, 2019

Conversation

philbull
Copy link
Collaborator

Scikit-learn has dropped Py2.7 support; use older versions for Py2.7 tests.

@philbull philbull self-assigned this May 10, 2019
@ghost ghost added the in progress label May 10, 2019
@philbull philbull added the bug label May 10, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.474% when pulling 8e62ec8 on sklearn_version into 1aec81b on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.474% when pulling 8e62ec8 on sklearn_version into 1aec81b on master.

saurabh-astro
saurabh-astro approved these changes May 10, 2019
View reviewed changes
Copy link
Collaborator

@saurabh-astro saurabh-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@acliu acliu merged commit 9fe0576 into master May 10, 2019
@ghost ghost removed the in progress label May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabh-astro saurabh-astro saurabh-astro approved these changes

Assignees

@philbull philbull

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@philbull @coveralls @saurabh-astro @acliu