Noise test update #203
Merged
Noise test update #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: hera_pspec/noise.py modified: hera_pspec/tests/test_noise.py modified: hera_pspec/tests/test_uvpspec.py modified: hera_pspec/uvpspec.py
modified: tests/test_noise.py modified: tests/test_uvpspec.py
ghost
assigned 
philbull
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor updates
1.) This updates how the sqrt(2) factor is propagated in our
P_Ncalculation to make it more clear to the user. Before this was done only at the highest level, class methodUVPSpec.generate_noise_spectravia thereal=Truekwarg. Now this is done at the lowest level,noise.calc_P_Nfunction via thecomponent='real'kwarg. Thecomponent='real'kwarg is then propagated through to thegenerate_noise_spectramethod.2.) This updates the metric we use to validate
P_Nintest_noise.py(RMS now instead of a standard deviation). the two are equivalent in this particular case (the reason why there was no test failure before), but the former is in principle more appropriate.