fix installation issues #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbull
reviewed
Jul 10, 2019
steven-murray
force-pushed
the
installation-issues
branch
from
325bb86
to
e219c76
Compare
|
Hmm I don't think coveralls is building off both py2 and py3 versions. Can you try adding: to the travis yml, that might make the coverage bot happy |
steven-murray
force-pushed
the
installation-issues
branch
from
32901e8
to
2ea9ce9
Compare
mkolopanis
approved these changes
Aug 27, 2019
There was a problem hiding this comment.
This all looks good to me. Consistent with installation changes in other repos too. Unless @philbull has any more comments.
philbull
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the installation order issue in the same way that
pyuvdatadid recently.Also adds some installation instructions and an
environment.ymlfor simpler installation of dev environment.Note that tests probably won't work until some of the upstream
herapackages have merged their PRs for this issue.