PR for pspec_graduation
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function, and in_units function
modified: hera_pspec/tests/test_version.py
…_pspec into pspec_graduation
modified: .travis.yml
* Placeholder comments added. * Some methods deprecated (to be removed or split out into utility library). * Warnings added to unsupported branches of the code * Code-style tidy-up, including more whitespace * Deprecate the redundant set_data() function * Rename 'Ctrue' -> 'C_empirical'
…to pspec_graduation
modified: hera_pspec/conversions.py new file: hera_pspec/tests/test_conversions.py
modified: hera_pspec/conversions.py modified: hera_pspec/tests/test_conversions.py
…pspec into pspec_graduation
until we completely graduatea utils module modified: hera_pspec/dataset.py
…to pspec_graduation
|
I'll review the code that @philbull committed, which was the @acliu if you also want to sign off on this that might be good too (I know you are busy so no pressure to actually review it). |
philbull
approved these changes
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a PR to graduate some of the basic code for
hera_pspec, includingdataset.py,version.pyandconversions.pywith tests. Thesetup.pyinstallation and travis testing environment are also graduated, and the oldpspec.pycode is also graduated for the purpose of backwards compatibility, although future PRs may eliminate this frommasterand move it to a branch.