Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pinhole util module #443

Merged
merged 1 commit into from
May 25, 2022
Merged

add pinhole util module #443

merged 1 commit into from
May 25, 2022

Conversation

joelvbernier
Copy link
Member

This module will house the utilities needed for applying pinhole camera corrections to apparent Bragg angle.

@joelvbernier joelvbernier added documentation Improvements or additions to documentation enhancement New feature or request high priority move these to the top of the stack labels May 23, 2022
@joelvbernier joelvbernier requested a review from psavery May 23, 2022 19:04
@joelvbernier joelvbernier self-assigned this May 23, 2022
psavery
psavery approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@psavery psavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joelvbernier joelvbernier merged commit 0a0add0 into master May 25, 2022
@psavery psavery deleted the pinhole-utils branch May 25, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psavery psavery psavery approved these changes

Assignees

@joelvbernier joelvbernier

Labels
documentation Improvements or additions to documentation enhancement New feature or request high priority move these to the top of the stack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joelvbernier @psavery