replacing "if" with "elif" in line 604 of materials.py. #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p a case with positive ions.
cjh1
approved these changes
Aug 24, 2022
|
@cjh1 Looks like some checks are failing. |
|
@saransh13 I think this is because of the updates that @joelvbernier made to examples for #454. I am guess it will be fixed when #454 is merged, @joelvbernier is that going to happen soon? Remember we don't have to cut 0.9.0 straight away. It would be good to have CI working though. |
|
Merging this since it only affects |
|
I'm may roll back that commit to examples until we are ready to merge both hexrd and hexrdgui's PR's with the new API for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was messing up a case with positive ions in the crystal.