Guard against unicode when saving HDF5 imageseries #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing out the [multiruby dexelas](https://github.com/HEXRD/examples/tree/master/NIST_ruby/multiruby_dexelas) example imageseries in hexrdgui after performing aggregation, I would encounter the following error: ``` TypeError: No conversion path for dtype: dtype('<U3') ``` It appears that some of the metadata being saved as HDF5 attributes was a unicode string. Specifically, for this case, it appears that the `panel_id` key had a unicode `ff1` value. Converting to a regular string fixes the issue. I don't know why the panel ID came out to have a unicode value, but we can guard against it and convert it into a regular string. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This is so that the CI will pass. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
cjh1
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing out the multiruby dexelas example imageseries in hexrdgui after
performing aggregation, I would encounter the following error:
It appears that some of the metadata being saved as HDF5 attributes
was a unicode string. Specifically, for this case, it appears that the
panel_idkey had a unicodeff1value.Converting to a regular string fixes the issue.
I don't know why the panel ID came out to have a unicode value, but
we can guard against it and convert it into a regular string.