Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rawimage.py #601

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Update rawimage.py #601

merged 1 commit into from
Jan 12, 2024

Conversation

darrencpagan
Copy link
Contributor

Bug found that when using this images series 'raw-images' option and calling the first image, the skip bytes wasn't being properly accounted for.

This change fixes it.

Bug found that when using this images series 'raw-images' option and calling the first image, the skip bytes wasn't being properly accounted for.

This change fixes it.
@pep8speaks
Copy link

Hello @darrencpagan! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 112:67: E261 at least two spaces before inline comment
Line 112:68: E262 inline comment should start with '# '
Line 112:80: E501 line too long (115 > 79 characters)

Copy link
Collaborator

@donald-e-boyce donald-e-boyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This is fine, but you could also have done:

self.f.seek(self.skipbytes, 0)

The second argument (0) means absolute positioning from the beginning of the file.

Change it if you like or just merge. I am approving the pull request.

@donald-e-boyce donald-e-boyce merged commit ae12b49 into HEXRD:master Jan 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants