Make __getitem__ for raw imageseries threadsafe #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that for multithreaded situations (such as writing out a frame cache), `__getitem__` will be thread-safe. The change ensures that the frame will be obtained immediately after seeking, and no other thread can seek until the frame is obtained. When I test the example Darren gave us (#608) on the master branch with no multithreading, it ran in 5m 36.826s. With this change, and using multithreading, it ran in 5m 12.811s. So the multithreading produced a minor speed increase. Fixes: #608 Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Since we were not evaluating the outputs of the threads before, the errors would not get propagated, leading to confusion. Propagating the errors ensures that users can see (and report) when they encounter an error. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
|
@donald-e-boyce Can you look over this? Feel free to run some of your tests to see if you notice a performance impact caused by the thread locking. |
donald-e-boyce
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that for multithreaded situations (such as writing out a frame cache),
__getitem__will be thread-safe. The change ensures that the frame will be obtained immediately after seeking, and no other thread can seek until the frame is obtained.When I test the example Darren gave us (#608) on the master branch with no multithreading, it ran in 5m 37s. With this change, and using multithreading, it ran in 5m 13s. So the multithreading produced a minor speed increase.
Fixes: #608