Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update numpy and qt in Ryan's pinhole script #633

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Update numpy and qt in Ryan's pinhole script #633

merged 1 commit into from
Apr 19, 2024

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Apr 16, 2024

These fixes are required to run it.

@psavery
Update numpy and qt in Ryan's pinhole script
9e23ef2 
These fixes are required to run it.

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
@psavery psavery requested a review from saransh13 April 16, 2024 20:59
@pep8speaks
Copy link

Hello @psavery! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 56:40: E202 whitespace before '}'
Line 115:46: E231 missing whitespace after ','
Line 117:46: E231 missing whitespace after ','

@psavery psavery merged commit 5e4ada3 into master Apr 19, 2024
6 checks passed
@psavery psavery deleted the fix-rygg-pinhole-script branch April 19, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saransh13 saransh13 Awaiting requested review from saransh13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psavery @pep8speaks