Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatibility: print function, absolute imports, ... #5

Merged
merged 1 commit into from
Jul 7, 2015
Merged

Python 3 compatibility: print function, absolute imports, ... #5

merged 1 commit into from
Jul 7, 2015

Conversation

ariddell
Copy link
Contributor

@ariddell ariddell commented Jul 7, 2015

'stage1' automatic conversion from python-future

'stage1' automatic conversion from python-future
@mattjj
Copy link
Contributor

mattjj commented Jul 7, 2015

Does this commit run under Python 2? I'm afk for an hour or so and I can't test it.

What else needs to be done for Python 3 compatibility?

@ariddell
Copy link
Contributor Author

ariddell commented Jul 7, 2015

Target is code that's 2.7 and 3 compatible. Seems to be working fine for me now in Python 3. The tests, such as they are, seemed to work fine under Python 2.7.

Thanks for the library. This is really handy.

slinderman added a commit that referenced this pull request Jul 7, 2015
Python 3 compatibility: print function, absolute imports, ...
@slinderman slinderman merged commit b16ca5c into HIPS:master Jul 7, 2015
@slinderman
Copy link
Contributor

Thanks! I tested it on 2.7 as well and didn't have any trouble. Glad you're finding it useful!

@mattjj
Copy link
Contributor

mattjj commented Jul 9, 2015

By the way, we have a DTM implementation in the dtm branch. We haven't tested it thoroughly or compared it to the variational EM method yet, so it hasn't been rolled into master, but I figured you might be interested in it!

@ariddell
Copy link
Contributor Author

ariddell commented Jul 9, 2015

I saw that! I've linked to pgmult from my aborted attempt to get
pg-DTM working https://github.com/ariddell/horizont

On 07/09, Matthew Johnson wrote:

By the way, we have a DTM implementation in the dtm branch. We haven't tested it thoroughly or compared it to the variational EM method yet, so it hasn't been rolled into master, but I figured you might be interested in it!


Reply to this email directly or view it on GitHub:
#5 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants