Graph #83
Merged
Graph #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matek2305
approved these changes
Aug 14, 2019
|
|
||
| Set<ServiceContracts> serviceContractsSet = environmentRepository.get(env).getAllServices().stream() | ||
| .map(service -> | ||
| serviceContractsRepository.find(service.getName(), service.getVersion()).orElseGet( |
There was a problem hiding this comment.
i would extract it to private method
| .map(service -> | ||
| serviceContractsRepository.find(service.getName(), service.getVersion()).orElseGet( | ||
| () -> new ServiceContracts(service.getName(), service.getVersion(), new HashMap<>(), new HashMap<>()))) | ||
| .collect(Collectors.toSet()); |
There was a problem hiding this comment.
maybe add another .map here to build dtos so below you will be able to write just return new InterrelationshipDto(env, serviceContractsSet);
| private final ServiceContractsRepository serviceContractsRepository; | ||
| private final ContractsMapper contractsMapper; | ||
|
|
||
| @Autowired |
There was a problem hiding this comment.
It was not used throughout the project in this case, we should introduce it globally
matek2305
approved these changes
Aug 14, 2019
garlicsauce
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.