Fix #3006

HMCL-dev · May 5, 2024 · bb4f87f · bb4f87f
1 parent df953e5
commit bb4f87f
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/VersionSettingsPage.java b/HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/VersionSettingsPage.java
@@ -30,7 +30,9 @@
 import javafx.scene.layout.*;
 import javafx.scene.text.Text;
 import javafx.stage.FileChooser;
-import org.jackhuang.hmcl.game.*;
+import org.jackhuang.hmcl.game.GameDirectoryType;
+import org.jackhuang.hmcl.game.HMCLGameRepository;
+import org.jackhuang.hmcl.game.ProcessPriority;
 import org.jackhuang.hmcl.setting.*;
 import org.jackhuang.hmcl.task.Schedulers;
 import org.jackhuang.hmcl.task.Task;
@@ -184,7 +186,7 @@ public VersionSettingsPage(boolean globalSetting) {
             gameDirSublist = new ComponentSublist();
             gameDirSublist.getContent().add(gameDirItem);
             gameDirSublist.setTitle(i18n("settings.game.working_directory"));
-            gameDirSublist.setHasSubtitle(true);
+            gameDirSublist.setHasSubtitle(versionId != null);
             gameDirItem.disableProperty().bind(modpack);
             gameDirCustomOption = new MultiFileItem.FileOption<>(i18n("settings.custom"), GameDirectoryType.CUSTOM)
                     .setChooserTitle(i18n("settings.game.working_directory.choose"))
@@ -609,14 +611,14 @@ private void initJavaSubtitle() {
         }
 
         Task.composeAsync(Schedulers.javafx(), () -> {
-            if (versionId == null) {
-                return versionSetting.getJavaVersion(GameVersionNumber.unknown(), null);
-            } else {
-                return versionSetting.getJavaVersion(
-                        GameVersionNumber.asGameVersion(profile.getRepository().getGameVersion(versionId)),
-                        profile.getRepository().getVersion(versionId));
-            }
-        }).thenAcceptAsync(Schedulers.javafx(), javaVersion -> javaSublist.setSubtitle(Optional.ofNullable(javaVersion)
+                    if (versionId == null) {
+                        return versionSetting.getJavaVersion(GameVersionNumber.unknown(), null);
+                    } else {
+                        return versionSetting.getJavaVersion(
+                                GameVersionNumber.asGameVersion(profile.getRepository().getGameVersion(versionId)),
+                                profile.getRepository().getVersion(versionId));
+                    }
+                }).thenAcceptAsync(Schedulers.javafx(), javaVersion -> javaSublist.setSubtitle(Optional.ofNullable(javaVersion)
                         .map(JavaVersion::getBinary).map(Path::toString).orElseGet(() ->
                                 autoSelected ? i18n("settings.game.java_directory.auto.not_found") : i18n("settings.game.java_directory.invalid"))))
                 .start();