Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] In version 22w45a+, selecting the Steve/Alex skin before launching the game results in the wrong skin #2784

Closed
3gf8jv4dv opened this issue Feb 12, 2024 · 7 comments
Labels

Comments

@3gf8jv4dv
Copy link
Contributor

3gf8jv4dv commented Feb 12, 2024

平台 | Platform

Windows 11

问题描述 | Problem Description

Commit: 59cc5b9

  1. Add an account
  2. Select the Steve or Alex skin in the Upload Skin interface
  3. Add an instance with game versions 22w45a+
  4. Start the instance and you will find that the skin may be different

I guess it has something to do with Mojang adding new default skins in 22w45a.
Java Edition 22w45a – Minecraft Wiki

The test results are shown below: #2784 (comment)

Using Local Skin File and LittleSkin does not seem to be affected. Blessing Skin is not tested.

启动器崩溃报告 / 启动器日志文件 | Launcher Crash Report / Launcher Log File

@3gf8jv4dv 3gf8jv4dv added the bug label Feb 12, 2024
@burningtnt
Copy link
Member

HMCL hasn't fully support to change you skin on offline accounts in these Minercraft versions.

@zkitefly
Copy link
Member

I tested it with 1.19.3 and it is indeed Alex skinned!

2024-02-12_17 18 08

Probably only the beta version has this problem

@burningtnt
Copy link
Member

Is this issue caused by the comparator of Game Version?
Could you test with the PR Collection version, as it contains PR #2700

@3gf8jv4dv
Copy link
Contributor Author

@burningtnt I’ll do it right away.

@3gf8jv4dv
Copy link
Contributor Author

3gf8jv4dv commented Feb 12, 2024

@burningtnt @zkitefly

My wording was inappropriate and too one-sided before. I apologize for this.
I added 3 offline accounts with different usernames and tested using 22w45a and 1.20.4.
Commit: burningtnt@67d0122

In the picture, the one on the left is the game version, the one in the middle is the username, and the one on the right is the skin type.

22w45a:

Details

1-1

1-2

1-3

1-4

1-5

1-6

1-7

1-8

1-9

1.20.4:

Details

2-1

2-2

2-3

2-4

2-5

2-6

2-7

2-8

2-9

@burningtnt
Copy link
Member

Thank you so much! I will check the codes and try to fix this.

@3gf8jv4dv 3gf8jv4dv changed the title [Bug] In version 22w45a+, selecting the Alex skin before launching the game results in the wrong skin [Bug] In version 22w45a+, selecting the Steve/Alex skin before launching the game results in the wrong skin Feb 12, 2024
@burningtnt
Copy link
Member

burningtnt commented Mar 14, 2024

The prediction from the UUID to a default skin hasn't support such Minecraft version. Therefore, when HMCL thought the UUID would provides Steve and doesn't launch a authlib-injector service, The skin calculated by Minecraft comes to another skin.

We will fix this bug later. As this is not a big problem, so it would not be traced in #2925.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants