Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to open62541 v1.4.0 #82

Merged
merged 26 commits into from
Mar 27, 2024
Merged

Upgrade to open62541 v1.4.0 #82

merged 26 commits into from
Mar 27, 2024

Conversation

sgoll
Copy link
Contributor

@sgoll sgoll commented Mar 22, 2024

Description

This upgrades our bindings for the upcoming 1.4 release of open62541.

Minor adjustments were necessary to accommodate for changes in the library's public API.

@sgoll
Copy link
Contributor Author

sgoll commented Mar 22, 2024

This is based on #81 and should only be merged after that PR.

The upgrade to open62541 1.4 has the advantage to allow us to drop the mutex when issuing library calls (the C library is now internally thread safe, mostly). It also enables us to asynchronously disconnect gracefully from a server endpoint.

I will remove our mutex in another PR on top of this one.

@sgoll sgoll marked this pull request as ready for review March 26, 2024 14:56
@sgoll sgoll requested a review from uklotzde March 26, 2024 14:56
.github/workflows/latest-dependencies.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
src/ua/secure_channel_state.rs Show resolved Hide resolved
@sgoll sgoll requested a review from uklotzde March 27, 2024 14:26
@uklotzde uklotzde merged commit 7e7571c into main Mar 27, 2024
13 checks passed
@uklotzde uklotzde deleted the open62541-1.4 branch March 27, 2024 14:38
sgoll added a commit that referenced this pull request Apr 4, 2024
## Description

This removes our own mutex for accessing the `UA_Client` instance. It is
not necessary anymore with open62541 1.4 (which we introduced in #82) as
most operations are protected by an internal mutex on the client
instance itself.

---------

Co-authored-by: Uwe Klotz <uwe.klotz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants