-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to open62541 v1.4.0 #82
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade to open62541 1.4 has the advantage to allow us to drop the mutex when issuing library calls (the C library is now internally thread safe, mostly). It also enables us to asynchronously disconnect gracefully from a server endpoint. I will remove our mutex in another PR on top of this one. |
This was referenced Mar 22, 2024
uklotzde
reviewed
Mar 27, 2024
uklotzde
approved these changes
Mar 27, 2024
sgoll
added a commit
that referenced
this pull request
Apr 4, 2024
## Description This removes our own mutex for accessing the `UA_Client` instance. It is not necessary anymore with open62541 1.4 (which we introduced in #82) as most operations are protected by an internal mutex on the client instance itself. --------- Co-authored-by: Uwe Klotz <uwe.klotz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This upgrades our bindings for the upcoming 1.4 release of open62541.
Minor adjustments were necessary to accommodate for changes in the library's public API.