Fixed (and confirmed) OpenTheory builds and exports after DIV/MOD changes #1122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR continues #1115, in which HOL4 now allows division-by-zero in
DIV
andMOD
.By renaming the old
DIV
andMOD
intoOT_DIV
andOT_MOD
, it's now quite easy to fix the OpenTheory builds (--otknl
), by just minor changes on symbol mapping. (NOTE: I also removed the infix setting ofOT_DIV
andOT_MOD
, because they look ugly as infix operators.)Now the div and mod operators are not OT's but belongs to the
arithmetic
package. I can see the following new OT theorems inhol-base
:while OpenTheory's original versions (
Number.Natural.div
andNumber.Natural.mod
, part of OT's own base package) is this:After long time building and installing (using the command sequence in #1121), I've built again the 900MB huge standalone OT article containing everything up to the Law of Large Numbers (in
examples/probability
) [1]. I confirm there's no "leaking" assumptions except for the 3 very axioms. Thus the OT build is still working. Below is a summary of all inference instructions involved (note the number of axioms is 3):[1] https://www.dropbox.com/s/kbsgaw9w9wjhp17/hol4-large-numbers-1.1b.7z?dl=0