Change behavior of MATCH_MP_TAC to fail only when being applied to a goal state #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… actual goal-state, instead of failing when given the first parameter
|
The documentation is vague about exactly when this error must occur, so I'm happy that this would not break any promises we have made. The fact that the regression tests pass is also encouraging. Thanks for the prompt to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beforehand the following tactic would fail, even if ACCEPT_TAC succeeds:
Now the tactic only fails, if ACCEPT_TAC failed and match_mp_tac either is not given an implication or cannot match the theorem with the conclusion being matched on.
For more details, see https://sourceforge.net/p/hol/mailman/message/36008112/