Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual tracking for characters does not work #130

Closed
Fahad-Alsaidi opened this issue Apr 3, 2016 · 6 comments
Closed

manual tracking for characters does not work #130

Fahad-Alsaidi opened this issue Apr 3, 2016 · 6 comments

Comments

@Fahad-Alsaidi
Copy link
Contributor

When you set manual tracking for chars it does not work.

@Fahad-Alsaidi Fahad-Alsaidi added this to the Complex text layout milestone Apr 3, 2016
@khaledhosny khaledhosny changed the title manual tracking for charismatics not working manual tracking for characters is not working Apr 4, 2016
@khaledhosny khaledhosny changed the title manual tracking for characters is not working manual tracking for characters does not work Apr 4, 2016
@Fahad-Alsaidi
Copy link
Contributor Author

@khaledhosny I found this in layout() function:
//TODO: cjk spacing and kerning should be done in layoutGlyphs!

could you elaborate more about this point ?

@khaledhosny khaledhosny self-assigned this Apr 10, 2016
@khaledhosny
Copy link

I don’t think this is related, the code this comment refers to is CJK specific. I’ll try to look into this issue and #141 as well.

@Fahad-Alsaidi
Copy link
Contributor Author

Last time I checked the code, all kerning code was removed from layout code
including CJK kerning.

@khaledhosny
Copy link

The so called CJK kerning is not kerning in the usual sense (it does not depend on the font) but special spacing rules to be applied to CJK ideographs and this code is definitely there, but untested. We need someone to test CJK functionality (line breaking, spacing) and report what works and what doesn't as we didn’t do any testing of this area at all. I opened #143 for that.

@khaledhosny
Copy link

Should be fixed now, please test.

khaledhosny added a commit that referenced this issue Apr 24, 2016
@Fahad-Alsaidi
Copy link
Contributor Author

I can confirm that it fixed.
@luzpaz please test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants