Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CJK support #143

Closed
khaledhosny opened this issue Apr 10, 2016 · 25 comments
Closed

Test CJK support #143

khaledhosny opened this issue Apr 10, 2016 · 25 comments

Comments

@khaledhosny
Copy link

We need someone to test CJK support and report what is working and what is broken, test files would be great as well.

@khaledhosny
Copy link
Author

@luzpaz do you know anyone who can work here, or do you at least have test documents from old Scribus issues?

@luzpaz
Copy link

luzpaz commented Apr 10, 2016

@ftake ping

@ftake
Copy link

ftake commented Apr 11, 2016

Has the latest code been merged into trunk? Or should I test the master branch of this repository?

@luzpaz
Copy link

luzpaz commented Apr 11, 2016

@ftake please test the CTL branch: https://github.com/HOST-Oman/scribus/tree/ctl.git
Thanks!

@luzpaz
Copy link

luzpaz commented Apr 11, 2016

BTW, it requires harfbuzz

@luzpaz
Copy link

luzpaz commented Apr 11, 2016

I've been searching old scribus issues and i'm pretty amazed of the lack of test documents.

@ftake
Copy link

ftake commented Apr 11, 2016

@ftake
Copy link

ftake commented Apr 11, 2016

I can not continue testing because scribus is killed with out of memory on my laptop.

As long as I tested quickly, there is problem with auto line break of CJK text.

@khaledhosny
Copy link
Author

@ftake providing test documents would be nice, especially for things that works on trunk (before or after boxes merge).

@ftake
Copy link

ftake commented Apr 11, 2016

Please use this:
geeko-magazine-vol11.1.pdf
vol11-2015-tokyo-fall.zip

@khaledhosny
Copy link
Author

OK, I see problems with line breaking indeed. I’m unable to edit any frames in this document, any idea why?

@luzpaz
Copy link

luzpaz commented Apr 11, 2016

Is that the CJK bug that doesn't allow editing text frames unless it in the Story Editor?

@khaledhosny
Copy link
Author

I can’t do almost anything with the file, not even selecting the frame or right clicking on them. Also almost all menu items are disabled.

@jiero
Copy link

jiero commented Apr 12, 2016

Hi, thanks for your works. Initially, I want to test and fetched the source, well then I found I have to get libs that's beyond my current knowledge -=- Looks like ftake is more capable of this task over me, and he would help.

Also I've been away from scribus for a couple of years, missing many updates and qt5 libs.
Maybe after system upgrade, these libs will become available and I will come back.

@Fahad-Alsaidi
Copy link
Contributor

@khaledhosny you need to exit from preview mode either from eye icon in the tool bar or from
view->preview->previewmode

@luzpaz
Copy link

luzpaz commented Apr 12, 2016

Here is the bug i was looking for: 13612 No input method preedit when one inputs CJ text directly into a text frame

@khaledhosny
Copy link
Author

@khaledhosny you need to exit from preview mode either from eye icon in the tool bar or from
view->preview->previewmode

Yes, that was it.

@khaledhosny
Copy link
Author

Here is the bug i was looking for: 13612

I suspect this issues is fixed or mostly fixed, but I need clear instructions on how to reproduce it since I don’t usually use any input methods.

@khaledhosny
Copy link
Author

OK, I think I found the root of the issue. I think (for some reason) we are repeatedly applying the CJK spacing adjustments to the same glyph. This seems to be the same underlying issue as https://bugs.scribus.net/view.php?id=13895, but the fix in trunk does not work with CTL code so we need a different strategy to fix it.

@luzpaz
Copy link

luzpaz commented Apr 13, 2016

@jiero what OS/platform are you on ?

@jiero
Copy link

jiero commented Apr 14, 2016

Currently on Ubuntu 15.10 GNOME, planed to move to 16.04 GNOME after
release. Okay, I will try to install it sooner with daily builds. And then
I think proper QT5 libs can be found on the newer repository.

Going to do the upgrade tonight.

On Wed, Apr 13, 2016 at 11:25 AM, luzpaz notifications@github.com wrote:

@jiero https://github.com/jiero what OS/platform are you on ?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#143 (comment)

@luzpaz
Copy link

luzpaz commented Apr 18, 2016

Another test file: https://bugs.scribus.net/view.php?id=7610 (See attached)

@khaledhosny
Copy link
Author

CJK spacing should be better now, there are still differences that I need to investigate.

@Fahad-Alsaidi
Copy link
Contributor

This doc
cjk-linebreaking.sla.gz
for test CJK line breaking

@khaledhosny
Copy link
Author

After merging #162, I think all obvious CJK issues are fixed. I’m closing this now and if new issues are found they should be reported separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants