Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we don’t modify GlyphClusters repeatedly during layout #153

Closed
khaledhosny opened this issue Apr 17, 2016 · 1 comment
Closed

Make sure we don’t modify GlyphClusters repeatedly during layout #153

khaledhosny opened this issue Apr 17, 2016 · 1 comment
Labels
bug layout regression
Milestone
Complex text layout

Comments

@khaledhosny
Copy link

The loop in PageItem_TextFrame::layout() often reloops over GlyphClusters and we end up modifying the cluster several times leading to wrong results (e.g. #143 and probably several other bugs). Wr probably should go back to copying the clusters in LineControl instead of passing them by reference.
@khaledhosny khaledhosny added this to the Complex text layout milestone Apr 17, 2016
khaledhosny added a commit that referenced this issue Apr 19, 2016
@khaledhosny
Try to go back to copying the clusters for each line
d25193e 
Fixes #153.
@khaledhosny
Copy link
Author

Should be more or less fixed now, lets see of testing shows that we broke something else.

khaledhosny added a commit that referenced this issue Apr 19, 2016
@khaledhosny
Try to match the behaviour of trunk a bit
b74b064 
Related to #153.
khaledhosny added a commit that referenced this issue Apr 19, 2016
@khaledhosny
Fixup previous code
b2e5234 
Make sure we are actually modifying the glyph cluster not a copy of it.

Related to #153.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug layout regression
Projects
None yet
Milestone
Complex text layout
Development

No branches or pull requests
1 participant
@khaledhosny