Remove unused methods, correct nil -> IIEmptyIssue.

Test more IIEmptyIssueManagement methods.
hpi-swa-teaching · Jul 22, 2016 · 5403ca3 · 5403ca3
1 parent 3cf1bb3
commit 5403ca3
Show file tree

Hide file tree

Showing 10 changed files with 28 additions and 21 deletions.
diff --git a/...Integration-Core.package/IIEmptyIssueManagement.class/instance/checkResponse.shouldBe..st b/...Integration-Core.package/IIEmptyIssueManagement.class/instance/checkResponse.shouldBe..st
diff --git a/...ckage/IIEmptyIssueManagement.class/instance/createIssueWithTitle.body.assignee.labels..st b/...ckage/IIEmptyIssueManagement.class/instance/createIssueWithTitle.body.assignee.labels..st
@@ -1,3 +1,3 @@
 issue creation
 createIssueWithTitle: title body: body assignee: assignee labels: labels
-	^ nil
+	^ IIEmptyIssue new
diff --git a/...tegration-Core.package/IIEmptyIssueManagement.class/instance/getIssuesForClass.isMeta..st b/...tegration-Core.package/IIEmptyIssueManagement.class/instance/getIssuesForClass.isMeta..st
diff --git a/packages/IssueIntegration-Core.package/IIEmptyIssueManagement.class/methodProperties.json b/packages/IssueIntegration-Core.package/IIEmptyIssueManagement.class/methodProperties.json
@@ -2,17 +2,15 @@
 	"class" : {
 		"getInstance" : "Axl 7/14/2016 14:04" },
 	"instance" : {
-		"checkResponse:shouldBe:" : "Axl 7/15/2016 13:17",
 		"closeIssue:" : "Axl 7/15/2016 13:17",
-		"createIssueWithTitle:body:assignee:labels:" : "Axl 7/21/2016 14:55",
+		"createIssueWithTitle:body:assignee:labels:" : "CF 7/22/2016 15:54",
 		"editIssue:assignee:" : "FR 7/3/2016 19:51",
 		"editIssue:body:" : "Axl 7/14/2016 20:23",
 		"editIssue:labels:" : "LG 7/10/2016 16:49",
 		"editIssue:title:" : "Axl 7/15/2016 13:18",
 		"editIssue:title:body:assignee:state:" : "AB 7/31/2015 17:18",
 		"getIssues" : "Axl 7/14/2016 20:23",
 		"getIssuesForClass:" : "Axl 7/14/2016 20:24",
-		"getIssuesForClass:isMeta:" : "Axl 7/14/2016 20:24",
 		"getIssuesForMethod:class:isMeta:" : "Axl 7/14/2016 20:24",
 		"getLabels" : "Axl 7/15/2016 18:36",
 		"getMyIssuesForClass:" : "Axl 7/14/2016 20:24",

diff --git a/packages/IssueIntegration-Core.package/monticello.meta/version b/packages/IssueIntegration-Core.package/monticello.meta/version
diff --git a/...ssueIntegration-Tests.package/IIEmptyIssueManagementTest.class/instance/testCloseIssue.st b/...ssueIntegration-Tests.package/IIEmptyIssueManagementTest.class/instance/testCloseIssue.st
diff --git a/...package/IIEmptyIssueManagementTest.class/instance/testMethodsWhoReturnEmptyCollections.st b/...package/IIEmptyIssueManagementTest.class/instance/testMethodsWhoReturnEmptyCollections.st
@@ -0,0 +1,7 @@
+running
+testMethodsWhoReturnEmptyCollections
+	| methods arguments |
+	methods := { #getIssues . #getIssuesForClass: . #getIssuesForMethod:class:isMeta: . #getMyIssuesForClass: . #getMyIssuesForMethod:class:isMeta: . #getLabels . #loadIssues . #loadLabels }.
+	arguments := { 'arg1' . 'arg2' . 'arg3' }.
+	methods do: [ :method | self assert: 
+		(self issueManagement perform: method withEnoughArguments: arguments) isEmpty ]
diff --git a/...gration-Tests.package/IIEmptyIssueManagementTest.class/instance/testNoOperationMethods.st b/...gration-Tests.package/IIEmptyIssueManagementTest.class/instance/testNoOperationMethods.st
@@ -0,0 +1,14 @@
+running
+testNoOperationMethods
+	| issue |
+	issue := IIEmptyIssue new.
+	self issueManagement 
+		closeIssue: issue;
+		createIssueWithTitle: '' body: '' assignee: '' labels: {};
+		editIssue: issue assignee: '';
+		editIssue: issue body: '';
+		editIssue: issue labels: {};
+		editIssue: issue title: '';
+		editIssue: issue title: '' body: '' assignee: '' state: '';
+		openIssueInWebBrowser: issue.
+	"If we reach here, all methods are implemented."
diff --git a/...ges/IssueIntegration-Tests.package/IIEmptyIssueManagementTest.class/methodProperties.json b/...ges/IssueIntegration-Tests.package/IIEmptyIssueManagementTest.class/methodProperties.json
@@ -5,6 +5,7 @@
 		"issueManagement" : "Axl 7/14/2016 20:33",
 		"issueManagement:" : "CF 6/26/2016 11:20",
 		"setUp" : "Axl 7/13/2016 10:05",
-		"testCloseIssue" : "FR 7/21/2016 15:08",
 		"testHasValidRemote" : "Axl 7/13/2016 10:05",
-		"testIsSingleton" : "FR 7/6/2016 21:42" } }
+		"testIsSingleton" : "FR 7/6/2016 21:42",
+		"testMethodsWhoReturnEmptyCollections" : "CF 7/22/2016 16:07",
+		"testNoOperationMethods" : "CF 7/22/2016 15:59" } }
diff --git a/packages/IssueIntegration-Tests.package/monticello.meta/version b/packages/IssueIntegration-Tests.package/monticello.meta/version