Skip to content

Commit

Permalink
Fix double slash in urls and rename GitHubApiMock to GitHubApiMockSer…
Browse files Browse the repository at this point in the history
…ver.
  • Loading branch information
cmfcmf committed Jul 22, 2016
1 parent bbb8410 commit 3cf1bb3
Show file tree
Hide file tree
Showing 60 changed files with 35 additions and 36 deletions.
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
as yet unclassified
generateUrlFromPath: aPath
^ 'https://api.github.com/' , aPath.
^ 'https://api.github.com' , aPath.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"apiRequestTo:withMethod:andExpectedCode:onError:" : "LG 7/21/2016 19:18",
"checkResponse:shouldBe:" : "LG 7/21/2016 18:55",
"errorForResponse:" : "CF 7/22/2016 08:18",
"generateUrlFromPath:" : "LG 7/21/2016 19:45",
"generateUrlFromPath:" : "CF 7/22/2016 15:48",
"initialize" : "LG 7/21/2016 19:33",
"oAuthToken" : "LG 7/21/2016 18:43",
"oAuthToken:" : "LG 7/21/2016 18:43",
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
as yet unclassified
testUrlGeneration
| path url |
path := 'repos/', IIGitHubApiMock repoSlug.
path := '/repos/', IIGitHubApiMockServer repoSlug.
url := self apiClient generateUrlFromPath: path.
self assert: 'https://api.github.com/', path equals: url
self assert: 'https://api.github.com', path equals: url
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
"setUp" : "LG 7/21/2016 20:00",
"testCheckResponse" : "CF 7/22/2016 08:18",
"testOAuthToken" : "FR 7/22/2016 09:34",
"testUrlGeneration" : "FR 7/22/2016 09:38",
"testUrlGeneration" : "CF 7/22/2016 15:47",
"testWebClient" : "FR 7/22/2016 09:33" } }
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
running
testRepoList
self assert: ((self repoList getList collect: [ :repo | repo asString ]) includes: IIGitHubApiMock repoSlug).
self assert: ((self repoList getList collect: [ :repo | repo asString ]) includes: IIGitHubApiMockServer repoSlug).
self assert: 0 equals: self repoList getCurrentSelectionIndex.
self assert: self issueList getList isEmpty.
self repoList changeModelSelection: 1.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"testIssueList" : "Axl 7/6/2016 13:00",
"testIssueWidgets" : "Axl 7/6/2016 13:00",
"testLabelList" : "FR 7/22/2016 10:24",
"testRepoList" : "Axl 7/20/2016 10:36",
"testRepoList" : "CF 7/22/2016 15:44",
"testSettingsButton" : "Axl 7/6/2016 13:01",
"testSmoke" : "Axl 7/6/2016 13:01",
"testSortOrder" : "Axl 7/6/2016 13:01" } }
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ testIssueManagementCreation
saveButton := self subject findByName: 'saveButton'.
saveAndQuitButton := self subject findByName: 'saveAndQuitButton'.
projectIdInput
changeText: IIGitHubApiMock repoSlug;
changeText: IIGitHubApiMockServer repoSlug;
acceptTextInModel.
usernameInput
changeText: IIGitHubApiMock repoOwner;
changeText: IIGitHubApiMockServer repoOwner;
acceptTextInModel.
loginKeyInput
changeText: 'i-am-not-a-key';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ testPackageSelection
self packageList changeModelSelection: (self packageList getList
indexOf: (self packageList getList
detect: [ :package | package = 'IssueIntegration-Tests'])).
self assert: (self subject findByName: 'projectIdInput') text equals: IIGitHubApiMock repoSlug.
self assert: (self subject findByName: 'usernameInput') text equals: IIGitHubApiMock repoOwner.
self assert: (self subject findByName: 'projectIdInput') text equals: IIGitHubApiMockServer repoSlug.
self assert: (self subject findByName: 'usernameInput') text equals: IIGitHubApiMockServer repoOwner.
self assert: (self subject findByName: 'loginKeyInput') text equals: 'i-am-not-a-key'
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
"testCheckLoginKey" : "LG 7/22/2016 09:31",
"testChoosingTestPackage" : "LG 7/22/2016 14:16",
"testInputValidation" : "FR 7/3/2016 21:23",
"testIssueManagementCreation" : "LG 7/22/2016 14:41",
"testIssueManagementCreation" : "CF 7/22/2016 15:45",
"testIssueManagementDeletion" : "LG 7/22/2016 14:40",
"testPackageList" : "LG 7/22/2016 14:19",
"testPackageSelection" : "CF 7/5/2016 21:51",
"testPackageSelection" : "CF 7/22/2016 15:45",
"testSmoke" : "Axl 7/6/2016 13:02",
"testUsernameError" : "LG 7/22/2016 13:56" } }
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
initialize-release
createMockIssueManagement
"Todo: statt MochWeClient MockApiClient"
| issueManagement apiClient |
issueManagement := IIGitHubIssueManagement createWithProjectID: IIGitHubApiMock
issueManagement := IIGitHubIssueManagement createWithProjectID: IIGitHubApiMockServer
repoSlug loginKey: 'i-am-not-a-key'
username: IIGitHubApiMock repoOwner.
username: IIGitHubApiMockServer repoOwner.
apiClient := IIGitHubApiMockClient new.
apiClient oAuthToken: 'i-am-not-a-key'.
issueManagement apiClient: apiClient.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ setUp
super setUp.
self oldRepositoryDictionary: IIIssueManagement repositoryDictionary copy.
IIIssueManagement repositoryDictionary removeAll.
self gitHubApiMock: IIGitHubApiMock start
self gitHubApiMock: IIGitHubApiMockServer start
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ initialize-release
tearDown
super tearDown.
IIIssueManagement repositoryDictionary removeAll addAll: self oldRepositoryDictionary.
IIGitHubApiMock stop
IIGitHubApiMockServer stop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
"class" : {
},
"instance" : {
"createMockIssueManagement" : "LG 7/22/2016 10:21",
"createMockIssueManagement" : "CF 7/22/2016 15:43",
"gitHubApiMock" : "CF 7/5/2016 23:49",
"gitHubApiMock:" : "CF 7/5/2016 23:49",
"oldRepositoryDictionary" : "Axl 7/14/2016 20:39",
"oldRepositoryDictionary:" : "Axl 7/14/2016 20:39",
"setUp" : "Axl 7/14/2016 20:39",
"tearDown" : "Axl 7/6/2016 12:47" } }
"setUp" : "CF 7/22/2016 15:44",
"tearDown" : "CF 7/22/2016 15:44" } }

Large diffs are not rendered by default.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
as yet unclassified
generateUrlFromPath: aPath
^ 'http://localhost:' , IIGitHubApiMock portNumber, aPath
^ 'http://localhost:' , IIGitHubApiMockServer portNumber, aPath
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
"class" : {
},
"instance" : {
"generateUrlFromPath:" : "LG 7/21/2016 19:46" } }
"generateUrlFromPath:" : "CF 7/22/2016 15:44" } }
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
as yet unclassified
start
IIGitHubApiMockServer stop.
^ IIGitHubApiMockServer new start
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
as yet unclassified
stop
IIGitHubApiMockServer allSubInstancesDo: [ :each | each webServer destroy ]
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"repoName" : "CF 6/10/2016 08:15",
"repoOwner" : "CF 6/10/2016 08:15",
"repoSlug" : "FR 6/14/2016 19:19",
"start" : "CF 7/5/2016 21:49",
"stop" : "Axl 7/14/2016 21:14" },
"start" : "CF 7/22/2016 15:43",
"stop" : "CF 7/22/2016 15:43" },
"instance" : {
"checkOAuthToken:" : "LG 7/22/2016 10:32",
"createIssueJsonWithTitle:body:andAssignee:" : "FR 6/26/2016 10:45",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"issues",
"issueNumber",
"labels" ],
"name" : "IIGitHubApiMock",
"name" : "IIGitHubApiMockServer",
"pools" : [
],
"super" : "Object",
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
(name 'IssueIntegration-Testserver-CF.13' message 'Remove unused methods and classes.' id 'bb4adc77-17d1-f74f-af4a-296a2136a31c' date '22 July 2016' time '1:37:51.706331 pm' author 'CF' ancestors ((name 'IssueIntegration-Testserver-Axl.12' message 'empty log message' id '71775a46-4bac-3e46-bcd7-df24e89e45a6' date '22 July 2016' time '1:19:06.260206 pm' author 'Axl' ancestors ((name 'IssueIntegration-Testserver-LG.11' message 'test für GitHubMockApi' id '1b8d961f-641e-394f-bbb3-6530a24c2129' date '22 July 2016' time '1:12:41.240534 pm' author 'LG' ancestors ((name 'IssueIntegration-Testserver-LG.10' message 'GitHubApiMockClient' id '22d5504a-e119-ad4b-ae51-e2593b1d3b78' date '21 July 2016' time '8:09:04.302812 pm' author 'LG' ancestors ((name 'IssueIntegration-Testserver-FR.9' message 'Test gefixxxxxt!' id '3f14cd39-82aa-0a47-a15e-0cf5f948bb53' date '21 July 2016' time '7:21:35.269891 pm' author 'FR' ancestors ((name 'IssueIntegration-Testserver-HR.8' message 'Labels entfernt' id '13feddff-f7fb-49c3-94c4-d60fc2e1059a' date '21 July 2016' time '5:27:57.316082 pm' author 'HR' ancestors ((name 'IssueIntegration-Testserver-Axl.7' message 'adds failing stuff' id '23502c30-34f9-eb40-8c1e-de8eeb46de13' date '21 July 2016' time '1:46:54.088286 pm' author 'Axl' ancestors ((name 'IssueIntegration-Testserver-HR.6' message 'LabelEdit-Test' id '27de36e3-8b90-4266-8d42-cf396e24b411' date '17 July 2016' time '3:41:00.835466 pm' author 'HR' ancestors ((name 'IssueIntegration-Testserver-Axl.5' message '2' id 'bcff5bd4-625d-a443-9caa-f1bf8d42ac2c' date '14 July 2016' time '9:25:24.63711 pm' author 'Axl' ancestors ((name 'IssueIntegration-Testserver-Axl.4' message '1' id '439d13c5-69d9-9b44-b33e-ef0ac416b4cc' date '14 July 2016' time '8:20:18.42111 pm' author 'Axl' ancestors ((name 'IssueIntegration-Testserver-FR.3' message 'Label Testing ermöglicht' id '0e779a15-59b2-f94d-8649-acd608a96a15' date '14 July 2016' time '11:54:47.877513 am' author 'FR' ancestors ((name 'IssueIntegration-Testserver-CF.2' message 'Use a Set instead of an OrderedCollection.' id 'e7583fc9-3bbd-9d49-b31b-cdbed70a07dd' date '7 July 2016' time '2:07:36.812582 pm' author 'CF' ancestors ((name 'IssueIntegration-Testserver-CF.1' message 'Add Testserver category.' id 'a4dc8e05-8ed2-3a49-be3f-505bdcda99c1' date '5 July 2016' time '9:57:40.385545 pm' author 'CF' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())
(name 'IssueIntegration-Testserver-CF.14' message 'Fix double slash in urls and rename GitHubApiMock to GitHubApiMockServer.' id '4dd62dc2-620e-244f-a111-d5b03fc2aa73' date '22 July 2016' time '3:50:19.650331 pm' author 'CF' ancestors ((name 'IssueIntegration-Testserver-CF.13' message 'Remove unused methods and classes.' id 'bb4adc77-17d1-f74f-af4a-296a2136a31c' date '22 July 2016' time '1:37:51.706331 pm' author 'CF' ancestors ((name 'IssueIntegration-Testserver-Axl.12' message 'empty log message' id '71775a46-4bac-3e46-bcd7-df24e89e45a6' date '22 July 2016' time '1:19:06.260206 pm' author 'Axl' ancestors ((name 'IssueIntegration-Testserver-LG.11' message 'test für GitHubMockApi' id '1b8d961f-641e-394f-bbb3-6530a24c2129' date '22 July 2016' time '1:12:41.240534 pm' author 'LG' ancestors ((name 'IssueIntegration-Testserver-LG.10' message 'GitHubApiMockClient' id '22d5504a-e119-ad4b-ae51-e2593b1d3b78' date '21 July 2016' time '8:09:04.302812 pm' author 'LG' ancestors ((name 'IssueIntegration-Testserver-FR.9' message 'Test gefixxxxxt!' id '3f14cd39-82aa-0a47-a15e-0cf5f948bb53' date '21 July 2016' time '7:21:35.269891 pm' author 'FR' ancestors ((name 'IssueIntegration-Testserver-HR.8' message 'Labels entfernt' id '13feddff-f7fb-49c3-94c4-d60fc2e1059a' date '21 July 2016' time '5:27:57.316082 pm' author 'HR' ancestors ((name 'IssueIntegration-Testserver-Axl.7' message 'adds failing stuff' id '23502c30-34f9-eb40-8c1e-de8eeb46de13' date '21 July 2016' time '1:46:54.088286 pm' author 'Axl' ancestors ((name 'IssueIntegration-Testserver-HR.6' message 'LabelEdit-Test' id '27de36e3-8b90-4266-8d42-cf396e24b411' date '17 July 2016' time '3:41:00.835466 pm' author 'HR' ancestors ((name 'IssueIntegration-Testserver-Axl.5' message '2' id 'bcff5bd4-625d-a443-9caa-f1bf8d42ac2c' date '14 July 2016' time '9:25:24.63711 pm' author 'Axl' ancestors ((name 'IssueIntegration-Testserver-Axl.4' message '1' id '439d13c5-69d9-9b44-b33e-ef0ac416b4cc' date '14 July 2016' time '8:20:18.42111 pm' author 'Axl' ancestors ((name 'IssueIntegration-Testserver-FR.3' message 'Label Testing ermöglicht' id '0e779a15-59b2-f94d-8649-acd608a96a15' date '14 July 2016' time '11:54:47.877513 am' author 'FR' ancestors ((name 'IssueIntegration-Testserver-CF.2' message 'Use a Set instead of an OrderedCollection.' id 'e7583fc9-3bbd-9d49-b31b-cdbed70a07dd' date '7 July 2016' time '2:07:36.812582 pm' author 'CF' ancestors ((name 'IssueIntegration-Testserver-CF.1' message 'Add Testserver category.' id 'a4dc8e05-8ed2-3a49-be3f-505bdcda99c1' date '5 July 2016' time '9:57:40.385545 pm' author 'CF' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())

0 comments on commit 3cf1bb3

Please sign in to comment.