-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use updated SSL libraries #160
[WIP] Use updated SSL libraries #160
Conversation
Despite these changes (which work) there are still strange errors appearing in htmlproofer that now do not seem to be related to underlying curl/ssl errors - I put some direct curl calls into the script to check that (e.g., https://travis-ci.org/HEP-SF/hep-sf.github.io/builds/276898283). So still some more work to understand those problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@graeme-a-stewart I have the feeling that your last set of commits should probably be squashed into one or 2 as they seem very fine grained... but this is a minor detail.
@graeme-a-stewart is the last errors you are mentioning purely random or are they affecting always the same (limited) set of URLs? If this is always the same URLs (but I'm afraid this is not the case), I'd suggest to add them in the ignore list for the time being and merging what we have so far as it should already been a huge improvement... |
Hi @jouvin - it's very consistently the same URLs that fail (e.g., https://conda.io/docs/), but these don't fail when directly accessed by curl, which is puzzling. A tidied up version of this PR should probably be taken to at least get the solved problems solved. I can prepare that tomorrow. |
If this is always the same URLs, I propose that for the time being, this PR includes them in the ignore list so that html_proofer can succeeds. After merging this first PR, we can try to follow up on the remaining issues... |
02261ec
to
d70d111
Compare
See instructions in file for how to add the data-proofer-ignore tag to any URLs that need it
To overcome connection problems with some sites in Debian Trusty add the shared libraries from a build of OpenSSL 1.0.2l. These libraries are added into LD_LIBRARY_PATH by the html-proofer wrapper script.
Note - this must run as root, not as the travis user
d70d111
to
adf04d4
Compare
These remain mysteries as they only fail inside the Travis CI environment, yet an underlying `curl` is completely ok.
Damn it! So I tidied up this branch, checked everything, then did a final commit to ignore all of the URLs with the mysterious failures (adding the Somehow they must be failing internally in |
At this point in time I would just go for a docker image in travis... as it is now things are not debuggable and every iteration is costly |
@graeme-a-stewart You should use the file |
OK, let's try again in #162 |
Use some updated SSL libraries, compiled from 1.0.2l, to overcome observed SSL connection errors when validating some https websites.